Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @types/node #1110

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 27, 2020

Update to the latest @types/node

Notes:

  • older versions of webpack-env declared a conflicting global so had to be updated
  • zone.js still declares a conflicting global. The solution is to disable type checking third party libs until it is updated.
  • the xhr plugin performance API thinks it is the node api when it is in fact the browser API, so an any had to be used.

@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #1110 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1110   +/-   ##
=======================================
  Coverage   92.36%   92.36%           
=======================================
  Files         115      115           
  Lines        3407     3407           
  Branches      686      686           
=======================================
  Hits         3147     3147           
  Misses        260      260           
Impacted Files Coverage Δ
...s/opentelemetry-plugin-xml-http-request/src/xhr.ts 79.12% <ø> (ø)

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mayurkale22 mayurkale22 merged commit 3dd5223 into open-telemetry:master May 27, 2020
@Flarna Flarna deleted the update-node-types branch June 12, 2020 21:16
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants