-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: left pad short b3 trace identifiers #1021
Merged
mayurkale22
merged 2 commits into
open-telemetry:master
from
dynatrace-oss-contrib:left-pad-b3
May 5, 2020
Merged
fix: left pad short b3 trace identifiers #1021
mayurkale22
merged 2 commits into
open-telemetry:master
from
dynatrace-oss-contrib:left-pad-b3
May 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
bg451,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
May 5, 2020 19:11
markwolff
approved these changes
May 5, 2020
mayurkale22
approved these changes
May 5, 2020
/cc @Aneurysm9 |
vmarchaud
approved these changes
May 5, 2020
Thanks for the quick attention. I think this works but may not be completely correct. The B3 spec says that the trace ID will be either 64-bit or 128-bit, so I would suggest validating that an incoming ID is either 16 or 32 hex digits. |
updated |
mayurkale22
approved these changes
May 5, 2020
mayurkale22
added
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
May 5, 2020
Aneurysm9
approved these changes
May 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
Merge:LGTM
This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1020