-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing error status handler #1005
Conversation
@dyladan I can add node14 to the circle tests on this PR, else I can confirm that they are passing locally w/ node14 |
Think they are fundamentally separate issues as this is a true bugfix and the other is just administration. Would prefer they keep separate pr/issue/commits |
Makes sense. Passing locally for me on node14, other than a compile error here. I'm assuming its a bootstrapping issue on my end. opentelemetry-js/packages/opentelemetry-plugin-grpc/test/grpc.test.ts Lines 314 to 316 in f1324c3
|
Codecov Report
@@ Coverage Diff @@
## master #1005 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 212 212
Lines 8805 8806 +1
Branches 796 796
=======================================
+ Hits 8365 8366 +1
Misses 440 440
|
Which problem is this PR solving?
Short description of the changes