Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing error status handler #1005

Merged
merged 3 commits into from
May 1, 2020

Conversation

markwolff
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Adds a missing error status handler. Confused on why existing unit tests didn't pick this up until nodejs14. Will investigate separately...

@dyladan dyladan added the bug Something isn't working label Apr 30, 2020
@markwolff
Copy link
Member Author

@dyladan I can add node14 to the circle tests on this PR, else I can confirm that they are passing locally w/ node14

@dyladan
Copy link
Member

dyladan commented Apr 30, 2020

Think they are fundamentally separate issues as this is a true bugfix and the other is just administration. Would prefer they keep separate pr/issue/commits

@markwolff
Copy link
Member Author

Makes sense. Passing locally for me on node14, other than a compile error here. I'm assuming its a bootstrapping issue on my end.

afterEach(() => {
context.disable();
});

@codecov-io
Copy link

codecov-io commented Apr 30, 2020

Codecov Report

Merging #1005 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1005   +/-   ##
=======================================
  Coverage   95.00%   95.00%           
=======================================
  Files         212      212           
  Lines        8805     8806    +1     
  Branches      796      796           
=======================================
+ Hits         8365     8366    +1     
  Misses        440      440           
Impacted Files Coverage Δ
packages/opentelemetry-plugin-grpc/src/grpc.ts 96.79% <100.00%> (+0.01%) ⬆️

@dyladan dyladan merged commit d246c54 into open-telemetry:master May 1, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC tests fail on Node.js 14
4 participants