-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(opentelemetry-plugin-xml-http-request): define span kind as CLIENT for xmlhttprequests #1002
fix(opentelemetry-plugin-xml-http-request): define span kind as CLIENT for xmlhttprequests #1002
Conversation
…T for xmlhttprequests
@ivansenic Thanks for taking the time to make that PR ! You'll just need to sign the CLA (see: https://identity.linuxfoundation.org/projects/cncf) |
@vmarchaud No problem. I signed the CLA. |
@obecny please take a look at this one. If you're ok I'll merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for the PR @ivansenic and welcome to Opentelemetry community! |
Codecov Report
@@ Coverage Diff @@
## master #1002 +/- ##
===========================================
- Coverage 95.00% 82.38% -12.62%
===========================================
Files 212 80 -132
Lines 8806 2101 -6705
Branches 796 296 -500
===========================================
- Hits 8366 1731 -6635
+ Misses 440 370 -70
|
@ivansenic please fix the lint ( |
@mayurkale22 Sorry for that, my bad.. Fixed and pushed. |
Which problem is this PR solving?
The
xml-http-request
plugin does not correctly set the span kind toCLIENT
when creating the span on the open method. This makes all spans that represent XHR requests having the default span kind ofINTERNAL
.Per spec
INTERNAL -> Default value. Indicates that the span is used internally.
, which in this case is not true and should beCLIENT -> Indicates that the span covers the client-side wrapper around an RPC or other remote request.
.Short description of the changes
One-liner to set the span kind to
CLIENT
.