Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename formatter to propagator #795

Closed
dyladan opened this issue Feb 19, 2020 · 3 comments · Fixed by #851
Closed

Rename formatter to propagator #795

dyladan opened this issue Feb 19, 2020 · 3 comments · Fixed by #851
Assignees
@dyladan
Labels
Discussion Issue or PR that needs/is extended discussion.
Milestone
Beta

Comments

@dyladan
Copy link
Member

dyladan commented Feb 19, 2020

Right now we have the HttpTextFormat interface as well as the B3Format, HttpTraceContextFormat, etc classes. The specification is using the term Propagator for this. We should decide what we want to call this interface and its various derived classes before we reach beta stability.
@dyladan dyladan added the Discussion Issue or PR that needs/is extended discussion. label Feb 19, 2020
@dyladan dyladan added this to the Beta milestone Feb 19, 2020
@mayurkale22
Copy link
Member

This is coming from the specs, I think we should open same issue there.

@dyladan dyladan mentioned this issue Feb 19, 2020
Closed
@dyladan
Copy link
Member Author

dyladan commented Feb 19, 2020

This is coming from the specs, I think we should open same issue there.

open-telemetry/opentelemetry-specification#480

@dyladan
Copy link
Member Author

dyladan commented Feb 20, 2020

In open-telemetry/opentelemetry-specification#480, they seemed to think it is better to have naming aligned. Java is apparently also renaming some things to be closer to spec wording.

@dyladan dyladan self-assigned this Feb 20, 2020
@dyladan dyladan mentioned this issue Mar 12, 2020
Merged
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@dyladan
chore: remove obecny from renovate config (open-telemetry#795)
2564a8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyladan dyladan

Labels
Discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

Rename formatter to propagator dynatrace-oss-contrib/opentelemetry-js
2 participants
@dyladan @mayurkale22