Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mongodb-core plugin, add support for mongodb > 3.3 #622

Closed
shaz1v opened this issue Dec 15, 2019 · 3 comments
Closed

mongodb-core plugin, add support for mongodb > 3.3 #622

shaz1v opened this issue Dec 15, 2019 · 3 comments
Assignees
@vmarchaud
Labels
feature-request
Milestone
Alpha v0.4

Comments

@shaz1v
Copy link

shaz1v commented Dec 15, 2019

Is your feature request related to a problem? Please describe.
#621

Describe the solution you'd like
Collect traces from MongoDB operations

Describe alternatives you've considered
Current plugin fails to collect traces when using mongodb > 3.3

Additional context
@vmarchaud pointed out that mongodb has changed something internally in versions > 3.3, which caused the plugin to no longer work on the new versions

Thanks!
@shaz1v shaz1v mentioned this issue Dec 15, 2019
Closed
@vmarchaud
Copy link
Member

For ref, see both #205 (comment) and #205 (comment)

@mayurkale22 mayurkale22 added the up-for-grabs Good for taking. Extra help will be provided by maintainers label Dec 17, 2019
@mayurkale22 mayurkale22 added this to the Alpha v0.4 milestone Dec 17, 2019
@vmarchaud
Copy link
Member

I've tried to implement the APM API thats designed to collect traces for mongodb operations. However they didn't fix the underlying design of their driver which loose the context, so we still need to patch every method to fix that.
I will try to re-implement the mongodb-core plugin to works with mongodb so we can support all versions.

@vmarchaud vmarchaud self-assigned this Dec 28, 2019
@vmarchaud vmarchaud removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Dec 28, 2019
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Dec 29, 2019
@vmarchaud
feat: port mongodb-core plugin to mongodb open-telemetry#622
8facb6e
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jan 1, 2020
@vmarchaud
feat: port mongodb-core plugin to mongodb open-telemetry#622
692ffc6
vmarchaud added a commit to vmarchaud/opentelemetry-js that referenced this issue Jan 3, 2020
@vmarchaud
feat: port mongodb-core plugin to mongodb open-telemetry#622
551749c
mayurkale22 pushed a commit that referenced this issue Jan 3, 2020
@vmarchaud @mayurkale22
feat: port mongodb-core plugin to mongodb #622 (#652)
53c40c1 
* feat: port mongodb-core plugin to mongodb #622

* chore: address PR comments
@vmarchaud
Copy link
Member

This has been released in the v0.3.2 version, @shaz1v if you want to test out !

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@meteorlxy
docs: add missing fetch instrumentation (open-telemetry#622)
ecde944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmarchaud vmarchaud

Labels
feature-request
Projects
None yet
Milestone
Alpha v0.4
Development

No branches or pull requests
3 participants
@vmarchaud @mayurkale22 @shaz1v