Skip to content

Enhance database reporting config #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dyladan opened this issue Dec 11, 2019 · 4 comments
Closed

Enhance database reporting config #614

dyladan opened this issue Dec 11, 2019 · 4 comments
Labels
Discussion Issue or PR that needs/is extended discussion.

Comments

@dyladan
Copy link
Member

dyladan commented Dec 11, 2019

Currently there is a config option named enhancedDatabaseReporting that is used by no plugins and is undocumented.

Should we keep the enhanced database reporting config

Since it currently does nothing and is undocumented, is it even worth keeping around?

If we do keep it, what should it do?

There are multiple database plugins (mysql, pg/pg-pool, mongodb-core) and there will likely be others. If we keep this config option, it should do the same thing for all db plugins

@pauldraper
Copy link
Contributor

If it's not used delete it.

Though two cents: plugins ought define separate interfaces with specific options.

new PgOpentelemetryPlugin({ enhancedReporting: true })

@dyladan
Copy link
Member Author

dyladan commented Oct 19, 2020

Though two cents: plugins ought define separate interfaces with specific options.

Yes this is the idea behind the new Instrumentation base. The old one unfortunately wasn't very flexible from a config/setup standpoint, but the new one will work exactly as you suggest here.

@vmarchaud vmarchaud added the Discussion Issue or PR that needs/is extended discussion. label Jul 4, 2021
@vmarchaud
Copy link
Member

Apparently this has been discused at the spec level "recently": open-telemetry/opentelemetry-specification#1659

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@pichlermarc
Copy link
Member

closing as this is not applicable to this repo anymore.

@pichlermarc pichlermarc closed this as not planned Won't fix, can't repro, duplicate, stale Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Development

No branches or pull requests

4 participants