-
Notifications
You must be signed in to change notification settings - Fork 882
Enhance database reporting config #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If it's not used delete it. Though two cents: plugins ought define separate interfaces with specific options. new PgOpentelemetryPlugin({ enhancedReporting: true }) |
Yes this is the idea behind the new Instrumentation base. The old one unfortunately wasn't very flexible from a config/setup standpoint, but the new one will work exactly as you suggest here. |
Apparently this has been discused at the spec level "recently": open-telemetry/opentelemetry-specification#1659 |
Co-authored-by: Yaniv Davidi <[email protected]>
closing as this is not applicable to this repo anymore. |
Currently there is a config option named
enhancedDatabaseReporting
that is used by no plugins and is undocumented.Should we keep the enhanced database reporting config
Since it currently does nothing and is undocumented, is it even worth keeping around?
If we do keep it, what should it do?
There are multiple database plugins (
mysql
,pg
/pg-pool
,mongodb-core
) and there will likely be others. If we keep this config option, it should do the same thing for all db pluginsThe text was updated successfully, but these errors were encountered: