Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make XHR browser plugin create child spans for CORS pre-flight requests #604

Closed
draffensperger opened this issue Dec 10, 2019 · 0 comments · Fixed by #595
Closed

Make XHR browser plugin create child spans for CORS pre-flight requests #604

draffensperger opened this issue Dec 10, 2019 · 0 comments · Fixed by #595

Comments

@draffensperger
Copy link
Contributor

In OpenCensus Web, we detected CORS preflight requests for XHRs by using the Resource Timing API data from the browser. When a preflight request was detected, we would create a child span for the preflight request, and attach relevant Resource Timing network event data to it (connection start, etc.)

See this OpenCensus Web readme doc about the XHR-Resource Timing join algorithm, and then perf-resource-timing-selector.ts for its code.

It would be great to have that functionality in OpenTelemetry as well. cc/ @obecny

@obecny obecny mentioned this issue Dec 10, 2019
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant