Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin-http] error in getAbsoluteUrl method #579

Closed
OlivierAlbertini opened this issue Nov 30, 2019 · 0 comments · Fixed by #580
Closed

[plugin-http] error in getAbsoluteUrl method #579

OlivierAlbertini opened this issue Nov 30, 2019 · 0 comments · Fixed by #580
Assignees
@OlivierAlbertini
Labels
bug Something isn't working

Comments

@OlivierAlbertini
Copy link
Member

host variable checks headers.host twice.

It should be let host = reqUrlObject.host || reqUrlObject.hostname || headers.host || 'localhost';

Additional context

Add any other context about the problem here.
We should make tests more strict.
@OlivierAlbertini OlivierAlbertini added the bug Something isn't working label Nov 30, 2019
OlivierAlbertini added a commit to OlivierAlbertini/opentelemetry-js that referenced this issue Nov 30, 2019
@OlivierAlbertini
fix(plugin-http): http.url attribute
320686b 
closes open-telemetry#579

Signed-off-by: Olivier Albertini <[email protected]>
@OlivierAlbertini OlivierAlbertini mentioned this issue Nov 30, 2019
Merged
OlivierAlbertini added a commit to OlivierAlbertini/opentelemetry-js that referenced this issue Nov 30, 2019
@OlivierAlbertini
fix(plugin-http): http.url attribute
f8694cf 
closes open-telemetry#579

Signed-off-by: Olivier Albertini <[email protected]>
OlivierAlbertini added a commit to OlivierAlbertini/opentelemetry-js that referenced this issue Nov 30, 2019
@OlivierAlbertini
fix(plugin-http): http.url attribute
c62df3e 
closes open-telemetry#579

Signed-off-by: Olivier Albertini <[email protected]>
@OlivierAlbertini OlivierAlbertini self-assigned this Nov 30, 2019
OlivierAlbertini added a commit to OlivierAlbertini/opentelemetry-js that referenced this issue Nov 30, 2019
@OlivierAlbertini
fix(plugin-http): http.url attribute
9773f9c 
closes open-telemetry#579

Signed-off-by: Olivier Albertini <[email protected]>
mayurkale22 pushed a commit that referenced this issue Dec 2, 2019
@OlivierAlbertini @mayurkale22
fix(plugin-http): http.url attribute (#580)
06d21e3 
closes #579

Signed-off-by: Olivier Albertini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlivierAlbertini OlivierAlbertini

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugin-http): http.url attribute OlivierAlbertini/opentelemetry-js
1 participant
@OlivierAlbertini