Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin/gRPC: Incorrect supportedVersion is provided #486

Closed
markwolff opened this issue Nov 5, 2019 · 0 comments · Fixed by #487
Closed

Plugin/gRPC: Incorrect supportedVersion is provided #486

markwolff opened this issue Nov 5, 2019 · 0 comments · Fixed by #487
Assignees
@markwolff
Labels
bug Something isn't working
Milestone
Alpha v0.3

Comments

@markwolff
Copy link
Member

Currently the plugin is set to support ^1.23.3, even though it will work for all of 1.* (and probably also 0.*). It should be updated to be 1.*
@markwolff markwolff added the bug Something isn't working label Nov 5, 2019
@markwolff markwolff mentioned this issue Nov 5, 2019
Merged
@markwolff markwolff self-assigned this Nov 6, 2019
@mayurkale22 mayurkale22 added this to the Alpha v0.3 milestone Nov 6, 2019
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@nirsky @vmarchaud
feat(aws-lambda): added request and response hooks (open-telemetry#486)
cf8b1f3 
Co-authored-by: Valentin Marchaud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markwolff markwolff

Labels
bug Something isn't working
Projects
None yet
Milestone
Alpha v0.3
Development

Successfully merging a pull request may close this issue.

fix(grpc): use correct supportedVersions markwolff/opentelemetry-js
2 participants
@markwolff @mayurkale22