Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverage runs take 2 min out of every circleci build #481

Closed
lizthegrey opened this issue Nov 4, 2019 · 6 comments
Closed

coverage runs take 2 min out of every circleci build #481

lizthegrey opened this issue Nov 4, 2019 · 6 comments
Labels
bug Something isn't working

Comments

@lizthegrey
Copy link
Member

lizthegrey commented Nov 4, 2019

See https://circleci.com/gh/markwolff/opentelemetry-js/673 for instance -- the fact that each different JS version is repeating the same code coverage (6x) reports results in extensive queuing for the entire otel organization.

Can you consider only running full coverage reports on a subset of environments?

@lizthegrey lizthegrey added the bug Something isn't working label Nov 4, 2019
@bogdandrutu
Copy link
Member

In Java we run coverage only for one version

@mayurkale22
Copy link
Member

I think it makes sense to remove code coverage from each different JS version and keep only two coverage report -> node (maybe node:11) and browser (node:12-browsers).

Also, somehow Install Dependencies job takes > 3m almost every time, need to do some investigation.

@mayurkale22
Copy link
Member

mayurkale22 commented Nov 6, 2019

Per SIG, these are the action items:

  1. Merge lint and docs jobs.
  2. Only install doc and lint dependencies (not a full install) - full install takes > 3mins.
  3. Only run coverage on latest node and browser build
  4. Investigate current caching mechanism

@lizthegrey
Copy link
Member Author

Thank you! Your sister SIGs appreciate it.

@mayurkale22
Copy link
Member

Merge lint and docs jobs.

Done in #495

Only install doc and lint dependencies (not a full install) - full install takes > 3mins.

Done in #498

Only run coverage on latest node and browser build

Done in #496

Investigate current caching mechanism

Done in #514

Also, we have removed duplicate compile step(#510) and redundant test from types package (#511).

Feel free to reopen the issue if there's something that all of these doesn't solve.

@lizthegrey
Copy link
Member Author

Thanks a million!

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants