Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IsRemote field to SpanContext, set by propagators #450

Closed
mayurkale22 opened this issue Oct 21, 2019 · 0 comments · Fixed by #451
Closed

Add IsRemote field to SpanContext, set by propagators #450

mayurkale22 opened this issue Oct 21, 2019 · 0 comments · Fixed by #451
Labels
feature-request good first issue Good for newcomers
Milestone
Alpha v0.2

Comments

@mayurkale22
Copy link
Member

Add a IsRemote field to SpanContext and set to true when deserializing a propagated SpanContext (from a remote parent).

Original issue: open-telemetry/opentelemetry-specification#187

SpanContext based on specs: https://github.com/tsloughter/opentelemetry-specification/blob/45ee51310c4f8504cbdcdc4c2c460f13ede7a394/specification/api-tracing.md#spancontext
@mayurkale22 mayurkale22 added good first issue Good for newcomers feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Oct 21, 2019
@mayurkale22 mayurkale22 added this to the Alpha v0.2 milestone Oct 21, 2019
@KaindlJulian KaindlJulian mentioned this issue Oct 22, 2019
Merged
@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Oct 22, 2019
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@Flarna @dyladan @vmarchaud
chore: prefer use of global TracerProvider/MeterProvider (open-teleme…
041508f 
…try#450)

Remove setting of TracerProvider in samples where it is actually not needed as the global TracerProvider should be preferred on default.

I found it also inconsistent to set a TracerProvider but no MeterProvider.

Co-authored-by: Daniel Dyla <[email protected]>
Co-authored-by: Valentin Marchaud <[email protected]>
Co-authored-by: Naseem <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request good first issue Good for newcomers
Projects
None yet
Milestone
Alpha v0.2
Development

Successfully merging a pull request may close this issue.

feat: add IsRemote field to SpanContext, set by propagators KaindlJulian/opentelemetry-js
1 participant
@mayurkale22