Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement LabelSet in metrics #441

Closed
mayurkale22 opened this issue Oct 18, 2019 · 2 comments · Fixed by #463
Closed

Implement LabelSet in metrics #441

mayurkale22 opened this issue Oct 18, 2019 · 2 comments · Fixed by #463
Assignees
@xiao-lix
Labels
feature-request
Milestone
Alpha v0.3

Comments

@mayurkale22
Copy link
Member

Based on the specs: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/api-metrics-user.md#label-set-calling-convention
@mayurkale22 mayurkale22 added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Oct 18, 2019
@xiao-lix
Copy link
Contributor

Would it be fine if I take this?

@OlivierAlbertini
Copy link
Member

Sure

@mayurkale22 mayurkale22 removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Oct 28, 2019
@xiao-lix xiao-lix mentioned this issue Oct 29, 2019
Merged
@mayurkale22 mayurkale22 added this to the Alpha v0.3 milestone Oct 31, 2019
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@kkruk-sumo
feat(instrumentation-document-load): documentLoad attributes enhancem…
209f336 
…ent (open-telemetry#441)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiao-lix xiao-lix

Labels
feature-request
Projects
None yet
Milestone
Alpha v0.3
Development

Successfully merging a pull request may close this issue.

feat: implement labelset xiao-lix/opentelemetry-js
3 participants
@OlivierAlbertini @mayurkale22 @xiao-lix