Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[context-zone-peer-dep] update zone.js dependency #4245

Closed
ghost opened this issue Nov 2, 2023 · 4 comments · Fixed by #4320
Closed

[context-zone-peer-dep] update zone.js dependency #4245

ghost opened this issue Nov 2, 2023 · 4 comments · Fixed by #4320
Labels
contribfest These small and isolated issues are suitable for Kubecon Contribfest dependencies Pull requests that update a dependency file good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@ghost
Copy link

ghost commented Nov 2, 2023 •
edited by dyladan
Loading

zone.js@>=0.13.0 is required by @angular/[email protected]
@ghost ghost changed the title When will there be support for zone.js@"~0.13.0" as it is required by @angular/[email protected] When will there be support for zone.js@"~0.13.0" by @opentelemetry/context-zone-peer-dep as it is required by @angular/[email protected] Nov 2, 2023
@dyladan dyladan changed the title When will there be support for zone.js@"~0.13.0" by @opentelemetry/context-zone-peer-dep as it is required by @angular/[email protected] [context-zone-peer-dep] update zone.js dependency Nov 8, 2023
@dyladan
Copy link
Member

dyladan commented Nov 8, 2023

Title and description updated

@dyladan dyladan added good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers dependencies Pull requests that update a dependency file contribfest These small and isolated issues are suitable for Kubecon Contribfest labels Nov 8, 2023
@eryue0220
Copy link

Could I have a try for this?

rodgerbrennan added a commit to rodgerbrennan/opentelemetry-js that referenced this issue Nov 22, 2023
@rodgerbrennan
chore(opentelemetry-context-zone-peer-dep):
a042172 
update deps to support angular 16
closes issue open-telemetry#4245

Signed-off-by: rbrennan <[email protected]>
@rodgerbrennan rodgerbrennan mentioned this issue Nov 22, 2023
Merged
@nmpcunha
Copy link

In the meanwhile, Angular 17 (with zone.js 0.14) is out there.
Should we still try to use this issue and the linked PR to consider this version?

@krechtern
Copy link

I' also facing this problem right now in my Angular 16 project. Would be nice if this could be resolved 🙌

legendecas pushed a commit that referenced this issue Jan 17, 2024
@rodgerbrennan @pichlermarc
chore(opentelemetry-context-zone-peer-dep): support zone.js ^v0.13.0 (#…
bf8714e 
…4320)

* chore(opentelemetry-context-zone-peer-dep):
update deps to support angular 16
closes issue #4245

Signed-off-by: rbrennan <[email protected]>

* update packages

* Revert "update packages"

This reverts commit 624df4e.

* chore: sync package-lock.json

* chore: sync package-lock.json

* chore: sync package-lock.json

* Update ZoneContextManager.test to use ES5 UMD bundle

* add changelog

* remove trailing space from changelog

---------

Signed-off-by: rbrennan <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
@jufab jufab mentioned this issue Jan 20, 2024
Open
Zirak pushed a commit to Zirak/opentelemetry-js that referenced this issue Sep 14, 2024
@rodgerbrennan @pichlermarc @Zirak
chore(opentelemetry-context-zone-peer-dep): support zone.js ^v0.13.0 (o…
5f7acf2 
…pen-telemetry#4320)

* chore(opentelemetry-context-zone-peer-dep):
update deps to support angular 16
closes issue open-telemetry#4245

Signed-off-by: rbrennan <[email protected]>

* update packages

* Revert "update packages"

This reverts commit 624df4e.

* chore: sync package-lock.json

* chore: sync package-lock.json

* chore: sync package-lock.json

* Update ZoneContextManager.test to use ES5 UMD bundle

* add changelog

* remove trailing space from changelog

---------

Signed-off-by: rbrennan <[email protected]>
Co-authored-by: Marc Pichler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribfest These small and isolated issues are suitable for Kubecon Contribfest dependencies Pull requests that update a dependency file good first issue Good for newcomers up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(opentelemetry-context-zone-peer-dep): support zone.js ^v0.13.0 rodgerbrennan/opentelemetry-js
4 participants
@dyladan @eryue0220 @krechtern @nmpcunha