Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set net.peer.name and net.peer.port on grpc client spans #3429

Closed
ty-elastic opened this issue Nov 20, 2022 · 0 comments · Fixed by #3430
Closed

Set net.peer.name and net.peer.port on grpc client spans #3429

ty-elastic opened this issue Nov 20, 2022 · 0 comments · Fixed by #3430
Assignees
@ty-elastic
Labels
feature-request

Comments

@ty-elastic
Copy link
Contributor

ty-elastic commented Nov 20, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

Some APMs want to see net.peer.name and net.peer.port set as an attribute on gRPC client spans to aid with service dependency mapping. Per the OTEL conventions for gRPC tracing, these are required to be set.

Describe the solution you'd like

Set net.peer.name and net.peer.port on gRPC client spans in instrumentation-grpc.

Additional context

PR forthcoming.
@ty-elastic ty-elastic mentioned this issue Nov 20, 2022
Merged
3 tasks
@ty-elastic ty-elastic changed the title Set peer.service on grpc client spans Set net.peer.name and net.peer.port on grpc client spans Nov 30, 2022
vmarchaud pushed a commit that referenced this issue Dec 5, 2022
@ty-elastic
feat(instrumentation-grpc): set net.peer.name and net.peer.port on cl…
6ea4b41 
…ient spans (#3430)

Fixes #3429
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ty-elastic ty-elastic

Labels
feature-request
Projects
None yet
Milestone
No milestone
1 participant
@ty-elastic