Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceAttributes #2299

Closed
obecny opened this issue Jun 23, 2021 · 3 comments
Closed

ResourceAttributes #2299

obecny opened this issue Jun 23, 2021 · 3 comments
Assignees
@weyert

Comments

@obecny
Copy link
Member

obecny commented Jun 23, 2021

Currently the package @opentelemetry/resources and @opentelemetry/semantic-conventions expose ResourceAttributes which might create the name collisions and confusions what is what. I would think of renaming one of them.
At first I thought of @opentelemetry/resources but it simply sounds already very good so maybe semantic conventions should be exposed under different name for example SemanticResourceAttributes ?
@weyert
Copy link
Contributor

weyert commented Jun 25, 2021

Yeah, sounds good to me

@blumamir
Copy link
Member

How about ResourceAttributesNames, or ResourceAttributeKeys for semantic-conventions?
as these are not the attributes themselves, only their names.

BTW, isn't this package auto-generated from the proto files in the specification repo?

@dyladan
Copy link
Member

dyladan commented Jun 30, 2021

Should mirror the naming scheme of hte span attributes and semantic conventions

weyert pushed a commit to weyert/opentelemetry-js that referenced this issue Jul 14, 2021
@tapico-weyert
feat: updated spec to v1.5.0 and renamed resource class
967785c 
Updated the specification to the latest version 1.5.0

Renamed the `ResourceAttributes` to `SemanticResourceAttributes`

fixes open-telemetry#2299
@weyert weyert mentioned this issue Jul 14, 2021
Merged
@dyladan dyladan closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weyert weyert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@weyert @obecny @dyladan @blumamir