You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please answer these questions before submitting a bug report.
What version of OpenTelemetry are you using?
I am using the most recent version of Opentelemetry 0.22
What version of Node are you using?
14.17.0
Please provide the code you used to setup the OpenTelemetry SDK
N/A
What did you do?
I am trying to write my own custom instrumentation of an internal package which is versioned using alpha, beta-packages. Currently, the InstrumentationBase has a function named isSupported which checks the module version against a list of allowed versions. The check uses satisfies -function of the semver-package only this function appears to ignore alpha, beta versions.
For example, if I am using the following code snippet:
and the package version is 2.0.0-beta.1 that then function isSupported returns false` which results in the package not being instrumented while its supported.
If possible, provide a recipe for reproducing the error.
What did you expect to see?
I expected to be able to instrument any package no matter which version with or without prerelease tags when using the * as supported version
What did you see instead?
The custom instrumentation is not happening
Additional context
I think this could be solved in multiple ways:
Allow to provide a custom isSupported-function implementation as part of the configuration for the InstrumentationBase-class
Allow to provide an opt-in configuration includePrerelease which passes the following configuration to the semver-package's satisfies-function: { includePrerelease }
Implement support for * as supported version which always return true in the isSupported-function
The text was updated successfully, but these errors were encountered:
Please answer these questions before submitting a bug report.
What version of OpenTelemetry are you using?
I am using the most recent version of Opentelemetry 0.22
What version of Node are you using?
14.17.0
Please provide the code you used to setup the OpenTelemetry SDK
N/A
What did you do?
I am trying to write my own custom instrumentation of an internal package which is versioned using
alpha
,beta
-packages. Currently, theInstrumentationBase
has a function namedisSupported
which checks the module version against a list of allowed versions. The check usessatisfies
-function of thesemver
-package only this function appears to ignorealpha
,beta
versions.For example, if I am using the following code snippet:
and the package version is
2.0.0-beta.1
that then functionisSupported returns
false` which results in the package not being instrumented while its supported.If possible, provide a recipe for reproducing the error.
What did you expect to see?
I expected to be able to instrument any package no matter which version with or without prerelease tags when using the
*
as supported versionWhat did you see instead?
The custom instrumentation is not happening
Additional context
I think this could be solved in multiple ways:
isSupported
-function implementation as part of the configuration for theInstrumentationBase
-classincludePrerelease
which passes the following configuration to thesemver
-package'ssatisfies
-function:{ includePrerelease }
*
as supported version which always returntrue
in theisSupported
-functionThe text was updated successfully, but these errors were encountered: