Example and tests for otel collector exporter is not updated still uses serviceName

[seanyu4296]

The opentelemetry collector exporter is not updated. In examples and tests, It still uses serviceName for config and looking at the codebase it does not expose that anymore.

I wonder how these got in if we use typescript

opentelemetry-js/packages/opentelemetry-exporter-collector/test/node/CollectorTraceExporter.test.ts

Line 61 in a3b7738

serviceName: 'basic-service',

opentelemetry-js/examples/collector-exporter-node/tracing.js

Line 15 in a3b7738

serviceName: 'basic-service',

I am also unsure what should be the practice now? Should this be how we configure serviceName now?
#2271

[delaneyj]

In the updated example just a heads up

import { ResourceAttributes } from '@opentelemetry/semantic-conventions'
import { Resource } from '@opentelemetry/resources'

both libraries also are still on 0.20.0

[seanyu4296]

Thanks @delaneyj 🙏

[dyladan]

The opentelemetry collector exporter is not updated. In examples and tests, It still uses serviceName for config and looking at the codebase it does not expose that anymore.

I wonder how these got in if we use typescript

opentelemetry-js/packages/opentelemetry-exporter-collector/test/node/CollectorTraceExporter.test.ts

Line 61 in a3b7738

serviceName: 'basic-service',

opentelemetry-js/examples/collector-exporter-node/tracing.js

Line 15 in a3b7738

serviceName: 'basic-service',

I am also unsure what should be the practice now? Should this be how we configure serviceName now?
#2271

The first one was allowed because of the as any on line 64.

The second one was allowed because examples aren't type checked.

[seanyu4296]

Can we remove the any then?

Ohhh I see how can we enable type checking in the examples do we add some github actions

[dyladan]

The examples aren't written in typescript. in order to enable type checking, they would need to be modified for it. This is something we've talked about in the past but just haven't gotten to

[dyladan]

Can we remove the any then?

Sure do you want to make a PR?

[mustafain117]

@dyladan Can you please assign this to me
CC: @alolita