Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load plugins when Node.js tracer is started #199

Closed
danielkhan opened this issue Aug 14, 2019 · 2 comments · Fixed by #252
Closed

Load plugins when Node.js tracer is started #199

danielkhan opened this issue Aug 14, 2019 · 2 comments · Fixed by #252
Assignees
@mayurkale22
Labels
feature-request

Comments

@danielkhan
Copy link
Contributor

Known modules like for HTTP or GRPC are wrapped by hooking into the module loader and we need to do that when the tracer is ready to use.
tracer.start() would be the ideal location to add this functionality.
@vmarchaud
Copy link
Member

PR: #168

@mayurkale22
Copy link
Member

I think good to have this issue, PR is still under review/discussion.

@mayurkale22 mayurkale22 reopened this Aug 14, 2019
@mayurkale22 mayurkale22 self-assigned this Aug 14, 2019
This was referenced Sep 10, 2019
Closed
Merged
jtmalinowski pushed a commit to jtmalinowski/opentelemetry-js that referenced this issue Feb 23, 2021
@obecny @jtmalinowski
v0.10.0 proposal (open-telemetry#199)
9461bab 
* chore: gitignore

* chore: tmp

* chore: upgrading to ver. 0.11.0, few small fixes

* chore: changelog v0.10.0

* chore: renaming package name "plugins-node-all" to "plugins-node-core-and-contrib"

* chore: fixing react plugin tests

* chore: updating changelog

* chore: updating changelog

* chore: renaming plugins-node-all to plugins-node-core-and-contrib
jtmalinowski pushed a commit to jtmalinowski/opentelemetry-js that referenced this issue Mar 8, 2021
@obecny @jtmalinowski
v0.10.0 proposal (open-telemetry#199)
256b5a2 
* chore: gitignore

* chore: tmp

* chore: upgrading to ver. 0.11.0, few small fixes

* chore: changelog v0.10.0

* chore: renaming package name "plugins-node-all" to "plugins-node-core-and-contrib"

* chore: fixing react plugin tests

* chore: updating changelog

* chore: updating changelog

* chore: renaming plugins-node-all to plugins-node-core-and-contrib
dyladan pushed a commit that referenced this issue Mar 29, 2021
@obecny @dyladan
v0.10.0 proposal (#199)
e559caf 
* chore: gitignore

* chore: tmp

* chore: upgrading to ver. 0.11.0, few small fixes

* chore: changelog v0.10.0

* chore: renaming package name "plugins-node-all" to "plugins-node-core-and-contrib"

* chore: fixing react plugin tests

* chore: updating changelog

* chore: updating changelog

* chore: renaming plugins-node-all to plugins-node-core-and-contrib
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@obecny
v0.10.0 proposal (open-telemetry#199)
6430737 
* chore: gitignore

* chore: tmp

* chore: upgrading to ver. 0.11.0, few small fixes

* chore: changelog v0.10.0

* chore: renaming package name "plugins-node-all" to "plugins-node-core-and-contrib"

* chore: fixing react plugin tests

* chore: updating changelog

* chore: updating changelog

* chore: renaming plugins-node-all to plugins-node-core-and-contrib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayurkale22 mayurkale22

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Node-Tracer): initialize plugin loader mayurkale22/opentelemetry-node
3 participants
@danielkhan @vmarchaud @mayurkale22