-
Notifications
You must be signed in to change notification settings - Fork 821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI Job to Run Benchmark and Publish Results #1312
Comments
Yes, I think a similar approach would be enough. I would push it to this repo. |
@dyladan Not sure if pushing to this repo will work from within CI, I'm not very familiar with CircleCI. Currently benchmark data is exported as JSON and stored with historical data. |
It should be implemented as a github action and can either be triggered by a master push, or a release publish. For an example of a release publish triggered build you can look at what we are doing for the docs right now at .github/workflows/docs.yml |
* feat(restify): add requestHook support The `requestHook` config option allows custom span handling per request layer. * fix(restify): pass config to super class As mentioned in the review, pass the instrumentation config to the parent class. That way the config is also stored when given to the initializer, rather only when using the `setConfig` function. * fix(restify): fix comment referencing restify type Update comment to reference to correct type from the `@types/restify` package. * fix(restify): import missing Span type Add the missing import reported by the linter. * fix(restify): fix issues reported by linter * fix(restify): fix comment referencing restify type Mention the package name exactly. * fix(restify): fix comment referencing restify type Co-authored-by: Amir Blum <[email protected]> * fix(restify): add missing import in restify test * feat(restify): add layer argument to requestHook Add the layerType argument to the requestHook function. This is like the following PR but for restify: open-telemetry/opentelemetry-js-contrib#1226 Move the LayerType from internal-types to types, because it's now used in a function used by users of the instrumentation package. Co-authored-by: Amir Blum <[email protected]>
Is your feature request related to a problem? Please describe.
Yes. Currently the script used to benchmark must be run manually. This can lead to out-of-date or missing benchmark performance data.
Describe the solution you'd like
I would like a new job added to the CI pipeline that would run the benchmark script, then publish the results as an artifact. This job could run on ever push or every release, or at some other interval.
Describe alternatives you've considered
The alternative is to keep running the script manually. As mentioned above, this may result in benchmark data being out-of-sync with the actual code. Automatically running the benchmark script and publishing the results will ensure that the two are always synchronized.
The text was updated successfully, but these errors were encountered: