We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
According to spec here about span sampling (https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#sampling), there are three flags representing how a span was exported:
NOT_RECORD
RECORD
RECORD_AND_SAMPLED
As for now, api.Sampler.shouldSample returns a boolean, representing sampling or not. It should return an enum to support all flags in spec.
api.Sampler.shouldSample
The text was updated successfully, but these errors were encountered:
Ah.. just noticed a TODO in the code doc. Anyway, I'm going for this.
Sorry, something went wrong.
chore: release main (open-telemetry#1033)
4fd73a4
legendecas
Successfully merging a pull request may close this issue.
According to spec here about span sampling (https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#sampling), there are three flags representing how a span was exported:
NOT_RECORD
, same as https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-api/src/trace/trace_flags.ts#L22, do nothing with the span.RECORD
, record span events but do not export span.RECORD_AND_SAMPLED
, record span events, and export span.As for now,
api.Sampler.shouldSample
returns a boolean, representing sampling or not. It should return an enum to support all flags in spec.The text was updated successfully, but these errors were encountered: