-
Notifications
You must be signed in to change notification settings - Fork 821
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(opentelemetry-api-metrics): Adding generics to `create{metricTyp…
…e}` (#3170) Co-authored-by: Daniel Dyla <[email protected]>
- Loading branch information
1 parent
b73c29d
commit f9f7fed
Showing
5 changed files
with
154 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
109 changes: 109 additions & 0 deletions
109
experimental/packages/opentelemetry-api-metrics/test/types/Metric.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| /* | ||
| * Copyright The OpenTelemetry Authors | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { Counter, UpDownCounter, Histogram } from '../../src'; | ||
|
|
||
| describe('Metric', () => { | ||
| describe('Counter', () =>{ | ||
| it('enable not to define any type', () => { | ||
| const counter: Counter = { | ||
| add(_value: number, _attribute: unknown) {} | ||
| }; | ||
| counter.add(1, { 'some-attribute': 'value' }); | ||
| }); | ||
|
|
||
| it('enable to use with type', () => { | ||
| type Attributes = { | ||
| 'some-attribute': string | ||
| }; | ||
| const counter: Counter<Attributes> = { | ||
| add(_value: number, _attribute: Attributes) {} | ||
| }; | ||
| counter.add(1, { 'some-attribute': 'value' }); | ||
| }); | ||
|
|
||
| it('disable wrong attributes by typing', () => { | ||
| type Attributes = { | ||
| 'some-attribute': string | ||
| }; | ||
| const counter: Counter<Attributes> = { | ||
| add(_value: number, _attribute: Attributes) {} | ||
| }; | ||
| // @ts-expect-error Expacting the type of Attributes | ||
| counter.add(1, { 'another-attribute': 'value' }); | ||
| }); | ||
| }); | ||
|
|
||
| describe('UpDownCounter', () =>{ | ||
| it('enable not to define any type', () => { | ||
| const counter: UpDownCounter = { | ||
| add(_value: number, _attribute: unknown) {} | ||
| }; | ||
| counter.add(1, { 'some-attribute': 'value' }); | ||
| }); | ||
|
|
||
| it('enable to use with type', () => { | ||
| type Attributes = { | ||
| 'some-attribute': string | ||
| }; | ||
| const counter: UpDownCounter<Attributes> = { | ||
| add(_value: number, _attribute: Attributes) {} | ||
| }; | ||
| counter.add(1, { 'some-attribute': 'value' }); | ||
| }); | ||
|
|
||
| it('disable wrong attributes by typing', () => { | ||
| type Attributes = { | ||
| 'some-attribute': string | ||
| }; | ||
| const counter: UpDownCounter<Attributes> = { | ||
| add(_value: number, _attribute: Attributes) {} | ||
| }; | ||
| // @ts-expect-error Expacting the type of Attributes | ||
| counter.add(1, { 'another-attribute': 'value' }); | ||
| }); | ||
| }); | ||
|
|
||
| describe('Histogram', () =>{ | ||
| it('enable not to define any type', () => { | ||
| const counter: Histogram = { | ||
| record(_value: number, _attribute: unknown) {} | ||
| }; | ||
| counter.record(1, { 'some-attribute': 'value' }); | ||
| }); | ||
|
|
||
| it('enable to use with type', () => { | ||
| type Attributes = { | ||
| 'some-attribute': string | ||
| }; | ||
| const counter: Histogram<Attributes> = { | ||
| record(_value: number, _attribute: Attributes) {} | ||
| }; | ||
| counter.record(1, { 'some-attribute': 'value' }); | ||
| }); | ||
|
|
||
| it('disable wrong attributes by typing', () => { | ||
| type Attributes = { | ||
| 'some-attribute': string | ||
| }; | ||
| const counter: Histogram<Attributes> = { | ||
| record(_value: number, _attribute: Attributes) {} | ||
| }; | ||
| // @ts-expect-error Expacting the type of Attributes | ||
| counter.record(1, { 'another-attribute': 'value' }); | ||
| }); | ||
| }); | ||
| }); |