fix: account for browser when mocking environment

open-telemetry · Dec 17, 2020 · f536638 · f536638
1 parent eb75af3
commit f536638
Showing 1 changed file with 15 additions and 2 deletions.
diff --git a/packages/opentelemetry-tracing/test/export/BatchSpanProcessor.test.ts b/packages/opentelemetry-tracing/test/export/BatchSpanProcessor.test.ts
@@ -76,16 +76,29 @@ describe('BatchSpanProcessor', () => {
     });
 
     it('should read defaults from environment', () => {
-      const envStub = sinon.stub(process, 'env').value({
+      const bspConfig = {
         OTEL_BSP_MAX_BATCH_SIZE: 256,
         OTEL_BSP_SCHEDULE_DELAY_MILLIS: 2500,
+      };
+
+      let env: Record<string, any>;
+      if (typeof process === 'undefined') {
+        env = (window as unknown) as Record<string, any>;
+      } else {
+        env = process.env as Record<string, any>;
+      }
+
+      Object.entries(bspConfig).forEach(([k, v]) => {
+        env[k] = v;
       });
+
       const processor = new BatchSpanProcessor(exporter);
       assert.ok(processor instanceof BatchSpanProcessor);
       assert.strictEqual(processor['_bufferSize'], 256);
       assert.strictEqual(processor['_bufferTimeout'], 2500);
       processor.shutdown();
-      envStub.restore();
+
+      Object.keys(bspConfig).forEach(k => delete env[k]);
     });
   });