feat(otel-grpc-exporter-base): support LogsService

open-telemetry · Apr 13, 2023 · e6214a6 · e6214a6
1 parent c0186cc
commit e6214a6
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 16 deletions.
diff --git a/experimental/packages/otlp-grpc-exporter-base/src/types.ts b/experimental/packages/otlp-grpc-exporter-base/src/types.ts
@@ -22,7 +22,7 @@ import {
 } from '@opentelemetry/otlp-exporter-base';
 
 /**
- * Queue item to be used to save temporary spans/metrics in case the GRPC service
+ * Queue item to be used to save temporary spans/metrics/logs in case the GRPC service
  * hasn't been fully initialized yet
  */
 export interface GRPCQueueItem<ExportedItem> {
@@ -32,7 +32,7 @@ export interface GRPCQueueItem<ExportedItem> {
 }
 
 /**
- * Service Client for sending spans or metrics
+ * Service Client for sending spans/metrics/logs
  */
 export interface ServiceClient extends grpc.Client {
   export: (
@@ -55,4 +55,5 @@ export interface OTLPGRPCExporterConfigNode extends OTLPExporterConfigBase {
 export enum ServiceClientType {
   SPANS,
   METRICS,
+  LOGS,
 }
diff --git a/experimental/packages/otlp-grpc-exporter-base/src/util.ts b/experimental/packages/otlp-grpc-exporter-base/src/util.ts
@@ -64,20 +64,31 @@ export function onInit<ExportItem, ServiceRequest>(
         'grpc.default_compression_algorithm': collector.compression,
       };
 
-      if (collector.getServiceClientType() === ServiceClientType.SPANS) {
-        collector.serviceClient =
-          new packageObject.opentelemetry.proto.collector.trace.v1.TraceService(
-            collector.url,
-            credentials,
-            options
-          );
-      } else {
-        collector.serviceClient =
-          new packageObject.opentelemetry.proto.collector.metrics.v1.MetricsService(
-            collector.url,
-            credentials,
-            options
-          );
+      switch (collector.getServiceClientType()) {
+        case ServiceClientType.SPANS:
+          collector.serviceClient =
+            new packageObject.opentelemetry.proto.collector.trace.v1.TraceService(
+              collector.url,
+              credentials,
+              options
+            );
+          break;
+        case ServiceClientType.METRICS:
+          collector.serviceClient =
+            new packageObject.opentelemetry.proto.collector.metrics.v1.MetricsService(
+              collector.url,
+              credentials,
+              options
+            );
+          break;
+        case ServiceClientType.LOGS:
+          collector.serviceClient =
+            new packageObject.opentelemetry.proto.collector.logs.v1.LogsService(
+              collector.url,
+              credentials,
+              options
+            );
+          break;
       }
 
       if (collector.grpcQueue.length > 0) {