Skip to content

Commit

Permalink
refactor(core): Use exported strings for semconv
Browse files Browse the repository at this point in the history
  • Loading branch information
JohannesHuster committed May 28, 2024
1 parent 969a16f commit e2b061a
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 14 deletions.
16 changes: 9 additions & 7 deletions packages/opentelemetry-core/src/platform/browser/sdk-info.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,17 @@

import { VERSION } from '../../version';
import {
TelemetrySdkLanguageValues,
SemanticResourceAttributes,
SEMRESATTRS_TELEMETRY_SDK_NAME,
SEMRESATTRS_PROCESS_RUNTIME_NAME,
SEMRESATTRS_TELEMETRY_SDK_LANGUAGE,
TELEMETRYSDKLANGUAGEVALUES_WEBJS,
SEMRESATTRS_TELEMETRY_SDK_VERSION,
} from '@opentelemetry/semantic-conventions';

/** Constants describing the SDK in use */
export const SDK_INFO = {
[SemanticResourceAttributes.TELEMETRY_SDK_NAME]: 'opentelemetry',
[SemanticResourceAttributes.PROCESS_RUNTIME_NAME]: 'browser',
[SemanticResourceAttributes.TELEMETRY_SDK_LANGUAGE]:
TelemetrySdkLanguageValues.WEBJS,
[SemanticResourceAttributes.TELEMETRY_SDK_VERSION]: VERSION,
[SEMRESATTRS_TELEMETRY_SDK_NAME]: 'opentelemetry',
[SEMRESATTRS_PROCESS_RUNTIME_NAME]: 'browser',
[SEMRESATTRS_TELEMETRY_SDK_LANGUAGE]: TELEMETRYSDKLANGUAGEVALUES_WEBJS,
[SEMRESATTRS_TELEMETRY_SDK_VERSION]: VERSION,
};
16 changes: 9 additions & 7 deletions packages/opentelemetry-core/src/platform/node/sdk-info.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,17 @@

import { VERSION } from '../../version';
import {
TelemetrySdkLanguageValues,
SemanticResourceAttributes,
SEMRESATTRS_TELEMETRY_SDK_NAME,
SEMRESATTRS_PROCESS_RUNTIME_NAME,
SEMRESATTRS_TELEMETRY_SDK_LANGUAGE,
TELEMETRYSDKLANGUAGEVALUES_NODEJS,
SEMRESATTRS_TELEMETRY_SDK_VERSION,
} from '@opentelemetry/semantic-conventions';

/** Constants describing the SDK in use */
export const SDK_INFO = {
[SemanticResourceAttributes.TELEMETRY_SDK_NAME]: 'opentelemetry',
[SemanticResourceAttributes.PROCESS_RUNTIME_NAME]: 'node',
[SemanticResourceAttributes.TELEMETRY_SDK_LANGUAGE]:
TelemetrySdkLanguageValues.NODEJS,
[SemanticResourceAttributes.TELEMETRY_SDK_VERSION]: VERSION,
[SEMRESATTRS_TELEMETRY_SDK_NAME]: 'opentelemetry',
[SEMRESATTRS_PROCESS_RUNTIME_NAME]: 'node',
[SEMRESATTRS_TELEMETRY_SDK_LANGUAGE]: TELEMETRYSDKLANGUAGEVALUES_NODEJS,
[SEMRESATTRS_TELEMETRY_SDK_VERSION]: VERSION,
};

0 comments on commit e2b061a

Please sign in to comment.