Do not multiwrap pool queries (#880)

* fix: do not multiwrap pool queries * chore: lint * chore: use wrap check from core
open-telemetry · Mar 19, 2020 · d2dc12f · d2dc12f
1 parent c812917
commit d2dc12f
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/packages/opentelemetry-plugin-mysql/src/mysql.ts b/packages/opentelemetry-plugin-mysql/src/mysql.ts
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-import { BasePlugin } from '@opentelemetry/core';
+import { BasePlugin, isWrapped } from '@opentelemetry/core';
 import { CanonicalCode, Span, SpanKind } from '@opentelemetry/api';
 import * as mysqlTypes from 'mysql';
 import * as shimmer from 'shimmer';
@@ -179,11 +179,13 @@ export class MysqlPlugin extends BasePlugin<typeof mysqlTypes> {
       if (arguments[1]) {
         // this is the callback passed into a query
         // no need to unwrap
-        shimmer.wrap(
-          arguments[1],
-          'query',
-          thisPlugin._patchQuery(arguments[1])
-        );
+        if (!isWrapped(arguments[1].query)) {
+          shimmer.wrap(
+            arguments[1],
+            'query',
+            thisPlugin._patchQuery(arguments[1])
+          );
+        }
       }
       if (typeof cb === 'function') {
         cb(...arguments);