fixup! node.js v14 compatibility and lint

open-telemetry · Apr 12, 2023 · 9ebae5e · 9ebae5e
1 parent 9dbbd3d
commit 9ebae5e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/experimental/packages/opentelemetry-instrumentation-http/src/http.ts b/experimental/packages/opentelemetry-instrumentation-http/src/http.ts
@@ -405,7 +405,10 @@ export class HttpInstrumentation extends InstrumentationBase<Http> {
           }
           responseFinished = true;
           utils.setSpanWithError(span, error);
-          span.setStatus({ code: SpanStatusCode.ERROR, message: error.message });
+          span.setStatus({
+            code: SpanStatusCode.ERROR,
+            message: error.message,
+          });
           this._closeHttpSpan(
             span,
             SpanKind.CLIENT,

diff --git a/...rimental/packages/opentelemetry-instrumentation-http/test/functionals/http-enable.test.ts b/...rimental/packages/opentelemetry-instrumentation-http/test/functionals/http-enable.test.ts
@@ -871,7 +871,7 @@ describe('HttpInstrumentation', () => {
       });
 
       it('should have 2 ended span when client prematurely close', async () => {
-        const promise = new Promise<void>((resolve) => {
+        const promise = new Promise<void>(resolve => {
           const req = http.get(
             `${protocol}://${hostname}:${serverPort}/hang`,
             res => {
@@ -948,10 +948,10 @@ describe('HttpInstrumentation', () => {
             },
             res => {
               res.on('end', () => {});
-              res.on('close', () => {});
-              res.on('error', () => {
+              res.on('close', () => {
                 resolve();
               });
+              res.on('error', () => {});
             }
           );
           // force flush http request header to trigger client response callback