chore: reword test descriptions

open-telemetry · Jun 16, 2021 · 963a344 · 963a344
1 parent a7cea78
commit 963a344
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/packages/opentelemetry-exporter-collector-grpc/test/CollectorExporterNodeBase.test.ts b/packages/opentelemetry-exporter-collector-grpc/test/CollectorExporterNodeBase.test.ts
@@ -88,7 +88,7 @@ describe('CollectorExporterNodeBase', () => {
       // Mock that all requests finish sending
       exporter.sendCallbacks.forEach(({ onSuccess }) => onSuccess());
 
-      // All finished promises should be dropped off
+      // All finished promises should be popped off
       await promisesAllDone;
       assert.strictEqual(exporter['_sendingPromises'].length, 0);
     });
@@ -106,12 +106,12 @@ describe('CollectorExporterNodeBase', () => {
       // Mock that all requests finish sending
       exporter.sendCallbacks.forEach(({ onSuccess }) => onSuccess());
 
-      // All finished promises should be dropped off
+      // All finished promises should be popped off
       await promisesAllDone;
       assert.strictEqual(exporter['_sendingPromises'].length, 0);
     });
 
-    it('should drop export requests even if they failed', async () => {
+    it('should pop export request promises even if they failed', async () => {
       const spans = [Object.assign({}, mockedReadableSpan)];
 
       exporter.export(spans, () => {});
@@ -122,12 +122,12 @@ describe('CollectorExporterNodeBase', () => {
         onError(new Error('Failed to send!!'))
       );
 
-      // All finished promises should be dropped off
+      // All finished promises should be popped off
       await promisesAllDone;
       assert.strictEqual(exporter['_sendingPromises'].length, 0);
     });
 
-    it('should drop export requests even if success callback throws error', async () => {
+    it('should pop export request promises even if success callback throws error', async () => {
       const spans = [Object.assign({}, mockedReadableSpan)];
 
       exporter['_sendPromise'](
@@ -145,7 +145,7 @@ describe('CollectorExporterNodeBase', () => {
         onSuccess();
       });
 
-      // All finished promises should be dropped off
+      // All finished promises should be popped off
       await promisesAllDone;
       assert.strictEqual(exporter['_sendingPromises'].length, 0);
     });