Skip to content

Commit

Permalink
chore: review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
dyladan committed Apr 7, 2021
1 parent 4392f48 commit 907acce
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ describe('HttpTraceContext', () => {
carrier,
defaultTextMapSetter
);
assert.deepStrictEqual(carrier[TRACE_PARENT_HEADER], undefined);
assert.deepStrictEqual(carrier[TRACE_STATE_HEADER], undefined);
assert.strictEqual(carrier[TRACE_PARENT_HEADER], undefined);
assert.strictEqual(carrier[TRACE_STATE_HEADER], undefined);
});
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,10 @@ describe('B3MultiPropagator', () => {
carrier,
defaultTextMapSetter
);
assert.deepStrictEqual(carrier[X_B3_TRACE_ID], undefined);
assert.deepStrictEqual(carrier[X_B3_SPAN_ID], undefined);
assert.deepStrictEqual(carrier[X_B3_FLAGS], undefined);
assert.deepStrictEqual(carrier[X_B3_PARENT_SPAN_ID], undefined);
assert.strictEqual(carrier[X_B3_TRACE_ID], undefined);
assert.strictEqual(carrier[X_B3_SPAN_ID], undefined);
assert.strictEqual(carrier[X_B3_FLAGS], undefined);
assert.strictEqual(carrier[X_B3_PARENT_SPAN_ID], undefined);
});
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ describe('JaegerHttpTracePropagator', () => {
carrier,
defaultTextMapSetter
);
assert.deepStrictEqual(carrier[UBER_TRACE_ID_HEADER], undefined);
assert.strictEqual(carrier[UBER_TRACE_ID_HEADER], undefined);
});
});

Expand Down

0 comments on commit 907acce

Please sign in to comment.