chore: remove use of NoopSpan

open-telemetry · Apr 15, 2020 · 82ba62e · 82ba62e
1 parent 344d9c0
commit 82ba62e
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/packages/opentelemetry-plugin-http/src/http.ts b/packages/opentelemetry-plugin-http/src/http.ts
@@ -24,7 +24,6 @@ import {
   Status,
   SpanContext,
   TraceFlags,
-  NoopSpan,
 } from '@opentelemetry/api';
 import {
   BasePlugin,
@@ -308,7 +307,7 @@ export class HttpPlugin extends BasePlugin<Http> {
       };
 
       return context.with(propagation.extract(headers), () => {
-        let span: Span = new NoopSpan();
+        let span: Span;
         const hasParent = plugin._tracer.getCurrentSpan() !== undefined;
         /*
          * If a parent is required but not present, we use a `NoRecordingSpan` to still
@@ -423,7 +422,7 @@ export class HttpPlugin extends BasePlugin<Http> {
         kind: SpanKind.CLIENT,
       };
       const hasParent = plugin._tracer.getCurrentSpan() !== undefined;
-      let span: Span = new NoopSpan();
+      let span: Span;
       /*
        * If a parent is required but not present, we use a `NoRecordingSpan` to still
        * propagate context without recording it.