fix: replace deprecated url.parse() with new url.URL()

Signed-off-by: naseemkullah <[email protected]>
open-telemetry · Jan 25, 2021 · 785ed66 · 785ed66
1 parent 6757653
commit 785ed66
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts b/packages/opentelemetry-exporter-prometheus/src/PrometheusExporter.ts
@@ -74,7 +74,9 @@ export class PrometheusExporter implements MetricExporter {
     ).replace(/^([^/])/, '/$1');
 
     if (config.preventServerStart !== true) {
-      this.startServer().then(callback).catch(err => this._logger.error(err));
+      this.startServer()
+        .then(callback)
+        .catch(err => this._logger.error(err));
     } else if (callback) {
       callback();
     }
@@ -176,7 +178,7 @@ export class PrometheusExporter implements MetricExporter {
     request: IncomingMessage,
     response: ServerResponse
   ) => {
-    if (url.parse(request.url!).pathname === this._endpoint) {
+    if (request.url && new url.URL(request.url).pathname === this._endpoint) {
       this._exportMetrics(response);
     } else {
       this._notFound(response);