Merge branch 'main' into fix/sdk-node-jaeger

open-telemetry · Apr 24, 2023 · 6ef1a03 · 6ef1a03
2 parents 58d481a + de354db
commit 6ef1a03
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/experimental/packages/sdk-logs/test/browser/export/BatchLogRecordProcessor.test.ts b/experimental/packages/sdk-logs/test/browser/export/BatchLogRecordProcessor.test.ts
@@ -24,8 +24,14 @@ import { InMemoryLogRecordExporter } from './../../../src/export/InMemoryLogReco
 const describeDocument =
   typeof document === 'object' ? describe : describe.skip;
 
+/**
+ * VisibilityState has been removed from TypeScript 4.6.0+
+ */
+type WebVisibilityState = 'visible' | 'hidden';
+
 describeDocument('BatchLogRecordProcessor - web main context', () => {
-  let visibilityState: VisibilityState = 'visible';
+  // TODO: change to DocumentVisibilityState when TypeScript is upgraded to 4.6+
+  let visibilityState: WebVisibilityState = 'visible';
   let exporter: LogRecordExporter;
   let processor: BatchLogRecordProcessor;
   let forceFlushSpy: sinon.SinonStub;

diff --git a/packages/opentelemetry-sdk-trace-base/test/browser/export/BatchSpanProcessor.test.ts b/packages/opentelemetry-sdk-trace-base/test/browser/export/BatchSpanProcessor.test.ts
@@ -30,6 +30,7 @@ const describeDocument =
   typeof document === 'object' ? describe : describe.skip;
 
 describeDocument('BatchSpanProcessor - web main context', () => {
+  // TODO: change to DocumentVisibilityState when TypeScript is upgraded to 4.6+
   let visibilityState: WebVisibilityState = 'visible';
   let exporter: SpanExporter;
   let processor: BatchSpanProcessor;