fix(resources): lint wait for async attributes for detecting resources

open-telemetry · May 9, 2024 · 56c21e9 · 56c21e9
1 parent a7044f3
commit 56c21e9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/packages/opentelemetry-resources/src/detect-resources.ts b/packages/opentelemetry-resources/src/detect-resources.ts
@@ -70,9 +70,7 @@ export const detectResourcesSync = (
         if (isPromiseLike<Resource>(resourceOrPromise)) {
           const createPromise = async () => {
             const resolvedResource = await resourceOrPromise;
-            if (resolvedResource.waitForAsyncAttributes) {
-              await resolvedResource.waitForAsyncAttributes();
-            }
+            // await resolvedResource.waitForAsyncAttributes?.();
             return resolvedResource.attributes;
           };
           resource = new Resource({}, createPromise());

diff --git a/packages/opentelemetry-resources/test/detect-resources.test.ts b/packages/opentelemetry-resources/test/detect-resources.test.ts
@@ -30,7 +30,7 @@ describe('detectResourcesSync', () => {
       async detect() {
         return new Resource(
           { sync: 'fromsync' },
-          Promise.resolve({ async: 'fromasync' }).then(attrs => attrs)
+          Promise.resolve().then(() => ({ async: 'fromasync' }))
         );
       },
     };