fix(opentelemetry-sdk-trace-web): Remove broken test and replace with…

… comment
open-telemetry · Apr 10, 2023 · 4ecedce · 4ecedce
1 parent 91401af
commit 4ecedce
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 16 deletions.
diff --git a/packages/opentelemetry-sdk-trace-web/src/utils.ts b/packages/opentelemetry-sdk-trace-web/src/utils.ts
@@ -309,7 +309,7 @@ export function parseUrl(url: string): URLLike {
       url,
       typeof document !== 'undefined'
         ? document.baseURI
-        : typeof location !== 'undefined'
+        : typeof location !== 'undefined' // Some JS runtimes (e.g. Deno) don't define this
         ? location.href
         : undefined
     );

diff --git a/packages/opentelemetry-sdk-trace-web/test/utils.test.ts b/packages/opentelemetry-sdk-trace-web/test/utils.test.ts
@@ -495,21 +495,6 @@ describe('utils', () => {
         assert.strictEqual(typeof url[field], 'string');
       });
     });
-
-    // Deno is an example of this
-    it('should parse url in runtimes where global location is not defined', () => {
-      const actualLocationObj = globalThis.location;
-      globalThis.location = undefined as any; // undefined is not allowed as a value normally, hence the any
-
-      try {
-        const url = parseUrl('https://opentelemetry.io/foo');
-        urlFields.forEach(field => {
-          assert.strictEqual(typeof url[field], 'string');
-        });
-      } finally {
-        globalThis.location = actualLocationObj;
-      }
-    });
   });
 
   describe('normalizeUrl', () => {