perf(propagator-jaeger): improve deserializeSpanContext performance

open-telemetry · Jan 30, 2023 · 071a32c · 071a32c
1 parent 279458e
commit 071a32c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,8 @@ For experimental package changes, see the [experimental CHANGELOG](experimental/
 
 ### :rocket: (Enhancement)
 
+* perf(propagator-jaeger): improve deserializeSpanContext performance [#3541](https://github.com/open-telemetry/opentelemetry-js/pull/3541) @doochik
+
 ### :bug: (Bug Fix)
 
 ### :books: (Refine Doc)

diff --git a/packages/opentelemetry-propagator-jaeger/src/JaegerPropagator.ts b/packages/opentelemetry-propagator-jaeger/src/JaegerPropagator.ts
@@ -134,6 +134,8 @@ export class JaegerPropagator implements TextMapPropagator {
   }
 }
 
+const VALID_HEX_RE = /^[0-9a-f]{1,2}$/i;
+
 /**
  * @param {string} serializedString - a serialized span context.
  * @return {SpanContext} - returns a span context represented by the serializedString.
@@ -148,9 +150,7 @@ function deserializeSpanContext(serializedString: string): SpanContext | null {
 
   const traceId = _traceId.padStart(32, '0');
   const spanId = _spanId.padStart(16, '0');
-  const traceFlags = flags.match(/^[0-9a-f]{1,2}$/i)
-    ? parseInt(flags, 16) & 1
-    : 1;
+  const traceFlags = VALID_HEX_RE.test(flags) ? parseInt(flags, 16) & 1 : 1;
 
   return { traceId, spanId, isRemote: true, traceFlags };
 }