refactor: always return a process resource

This commit introduces a slight change in behavior. Previously the
ProcessDectector would validate that it received attributes that it
expected, and returned an empty Resource if it didn't. Based on the
types, and the implementation of the ProcessDetector, there will
always be a valid ProcessResource. Collection of many of the attributes
can be done as a best effort without violating the specification.

packages/opentelemetry-resources/src/platform/browser/index.ts

@@ -21,4 +21,3 @@ export * from './HostDetectorSync';
 export * from './OSDetectorSync';
 export * from './ProcessDetector';
 export * from './ProcessDetectorSync';
-

packages/opentelemetry-resources/src/platform/node/ProcessDetectorSync.ts

@@ -27,7 +27,7 @@ import * as os from 'os';
  * and being instrumented from the NodeJS Process module.
  */
 class ProcessDetectorSync implements DetectorSync {
-  detect(config?: ResourceDetectionConfig): IResource {
+  detect(_config?: ResourceDetectionConfig): IResource {
     const attributes: ResourceAttributes = {
       [SemanticResourceAttributes.PROCESS_PID]: process.pid,
       [SemanticResourceAttributes.PROCESS_EXECUTABLE_NAME]: process.title,
@@ -51,38 +51,7 @@ class ProcessDetectorSync implements DetectorSync {
       diag.debug(`error obtaining process owner: ${e}`);
     }
 
-    return this._getResourceAttributes(attributes, config);
-  }
-
-  /**
-   * Validates process resource attribute map from process variables
-   *
-   * @param processResource The unsantized resource attributes from process as key/value pairs.
-   * @param config: Config
-   * @returns The sanitized resource attributes.
-   */
-  private _getResourceAttributes(
-    processResource: ResourceAttributes,
-    _config?: ResourceDetectionConfig
-  ) {
-    if (
-      processResource[SemanticResourceAttributes.PROCESS_EXECUTABLE_NAME] ===
-        '' ||
-      processResource[SemanticResourceAttributes.PROCESS_EXECUTABLE_PATH] ===
-        '' ||
-      processResource[SemanticResourceAttributes.PROCESS_COMMAND] === '' ||
-      processResource[SemanticResourceAttributes.PROCESS_COMMAND_LINE] === '' ||
-      processResource[SemanticResourceAttributes.PROCESS_RUNTIME_VERSION] === ''
-    ) {
-      diag.debug(
-        'ProcessDetector failed: Unable to find required process resources. '
-      );
-      return Resource.empty();
-    } else {
-      return new Resource({
-        ...processResource,
-      });
-    }
+    return new Resource(attributes);
   }
 }
 

packages/opentelemetry-resources/test/detectors/node/ProcessDetector.test.ts

@@ -15,10 +15,7 @@
  */
 import * as sinon from 'sinon';
 import { processDetector, IResource } from '../../../src';
-import {
-  assertResource,
-  assertEmptyResource,
-} from '../../util/resource-assertions';
+import { assertResource } from '../../util/resource-assertions';
 import { describeNode } from '../../util';
 import * as os from 'os';
 
@@ -52,11 +49,19 @@ describeNode('processDetector() on Node.js', () => {
       runtimeName: 'nodejs',
     });
   });
-  it('should return empty resources if title, command and commondLine is missing', async () => {
+
+  it('should return a resources if title, command and commondLine are missing', async () => {
     sinon.stub(process, 'pid').value(1234);
-    sinon.stub(process, 'title').value(undefined);
+    sinon.stub(process, 'title').value('');
     sinon.stub(process, 'argv').value([]);
+    sinon.stub(process, 'versions').value({ node: '1.4.1' });
     const resource: IResource = await processDetector.detect();
-    assertEmptyResource(resource);
+    // at a minium we should be able to rely on pid runtime, runtime name, and description
+    assertResource(resource, {
+      pid: 1234,
+      version: '1.4.1',
+      runtimeDescription: 'Node.js',
+      runtimeName: 'nodejs',
+    });
   });
 });