Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: converting pg plugin and pg-pool to instrumentation #350

Merged
merged 12 commits into from
Feb 25, 2021
Merged

chore: converting pg plugin and pg-pool to instrumentation #350

merged 12 commits into from
Feb 25, 2021

Conversation

obecny
Copy link
Member

@obecny obecny commented Feb 15, 2021

Which problem is this PR solving?

Short description of the changes

  • Move pg plugin and pg-pool to one instrumentation
  • Update example

@obecny obecny added the enhancement New feature or request label Feb 15, 2021
@obecny obecny requested a review from a team February 15, 2021 18:57
@obecny obecny self-assigned this Feb 15, 2021
@codecov
Copy link

codecov bot commented Feb 15, 2021 •
edited
Loading

Codecov Report

Merging #350 (aee8986) into main (74d371c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #350   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files          12       12           
  Lines         409      409           
  Branches       45       45           
=======================================
  Hits          384      384           
  Misses         25       25

vmarchaud
vmarchaud reviewed Feb 15, 2021
View reviewed changes
plugins/node/opentelemetry-instrumentation-pg/src/enums.ts
* limitations under the License.
*/

export enum AttributeNames {
Copy link
Member

@vmarchaud vmarchaud Feb 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe we can replace some of them by semantics-convention ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that this should be done. But I think it should be moved to a different PR to ease review.

plugins/node/opentelemetry-instrumentation-pg/src/pg.ts Outdated Show resolved Hide resolved
plugins/node/opentelemetry-instrumentation-pg/src/pg.ts Show resolved Hide resolved
plugins/node/opentelemetry-plugin-pg/src/enums.ts Outdated Show resolved Hide resolved
plugins/node/opentelemetry-instrumentation-pg/README.md Outdated Show resolved Hide resolved
@vmarchaud vmarchaud mentioned this pull request Feb 16, 2021
Closed
@obecny obecny requested a review from dyladan February 19, 2021 15:02
@obecny obecny merged commit 16e87fa into open-telemetry:main Feb 25, 2021
@obecny obecny deleted the instrumentation-pg branch February 25, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@dyladan dyladan dyladan approved these changes

Assignees

@obecny obecny

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert pg plugin to instrumentation Convert pg-pool plugin to instrumentation
4 participants
@obecny @dyladan @vmarchaud @Flarna