Skip to content

fix(instrumentation-openai)!: add missing access modifiers to private methods #3242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pichlermarc merged 1 commit into from
Nov 24, 2025
Merged

fix(instrumentation-openai)!: add missing access modifiers to private methods #3242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions packages/instrumentation-openai/src/instrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ export class OpenAIInstrumentation extends InstrumentationBase<OpenAIInstrumenta
);
}

_getPatchedChatCompletionsCreate(): any {
private _getPatchedChatCompletionsCreate(): any {
const self = this;
return (original: ChatCompletions['create']) => {
// https://platform.openai.com/docs/api-reference/chat/create
Expand Down Expand Up @@ -251,7 +251,7 @@ export class OpenAIInstrumentation extends InstrumentationBase<OpenAIInstrumenta
* Start a span for this chat-completion API call. This also emits log events
* as appropriate for the request params.
*/
_startChatCompletionsSpan(
private _startChatCompletionsSpan(
params: ChatCompletionCreateParams,
config: OpenAIInstrumentationConfig,
baseURL: string | undefined
Expand Down Expand Up @@ -449,7 +449,7 @@ export class OpenAIInstrumentation extends InstrumentationBase<OpenAIInstrumenta
* async iterator. It should yield the chunks unchanged, and gather telemetry
* data from those chunks, then end the span.
*/
async *_onChatCompletionsStreamIterator(
private async *_onChatCompletionsStreamIterator(
streamIter: AsyncIterator<ChatCompletionChunk>,
span: Span,
startNow: number,
Expand Down Expand Up @@ -604,7 +604,7 @@ export class OpenAIInstrumentation extends InstrumentationBase<OpenAIInstrumenta
span.end();
}

_onChatCompletionsCreateResult(
private _onChatCompletionsCreateResult(
span: Span,
startNow: number,
commonAttrs: Attributes,
Expand Down Expand Up @@ -702,7 +702,7 @@ export class OpenAIInstrumentation extends InstrumentationBase<OpenAIInstrumenta
span.end();
}

_createAPIPromiseRejectionHandler(
private _createAPIPromiseRejectionHandler(
startNow: number,
span: Span,
commonAttrs: Attributes
Expand Down Expand Up @@ -734,7 +734,7 @@ export class OpenAIInstrumentation extends InstrumentationBase<OpenAIInstrumenta
};
}

_getPatchedEmbeddingsCreate(): any {
private _getPatchedEmbeddingsCreate(): any {
const self = this;
return (original: Embeddings['create']) => {
// https://platform.openai.com/docs/api-reference/embeddings/create
Expand Down Expand Up @@ -778,7 +778,7 @@ export class OpenAIInstrumentation extends InstrumentationBase<OpenAIInstrumenta
* Start a span for this chat-completion API call. This also emits log events
* as appropriate for the request params.
*/
_startEmbeddingsSpan(
private _startEmbeddingsSpan(
params: EmbeddingCreateParams,
baseURL: string | undefined
) {
Expand Down Expand Up @@ -810,7 +810,7 @@ export class OpenAIInstrumentation extends InstrumentationBase<OpenAIInstrumenta
return { span, ctx, commonAttrs };
}

_onEmbeddingsCreateResult(
private _onEmbeddingsCreateResult(
span: Span,
startNow: number,
commonAttrs: Attributes,
Expand Down
Loading