feat(tedious): context propagation to SQL Server#3141
feat(tedious): context propagation to SQL Server#3141trentm merged 11 commits intoopen-telemetry:mainfrom
Conversation
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
| cfg.enableTraceContextPropagation && | ||
| thisPlugin._shouldInjectFor(operation); | ||
|
|
||
| if (!shouldInject) return runUserRequest(); |
There was a problem hiding this comment.
The previous code and this code path will return the return value of the originalMethod() call, which is typically what is wanted when wrapping. The _injectContextInfo() code path below this will not. I gather that won't matter for this instrumentation because, at least currently, every patched method's return type is void.
Calls
set context_infobefore methods that actually execute user's SQL(omitting prepare and execBulkLoad). Relevant specification. This is opt in as it causes an extra round trip per request. .NET PR for the same thing