chore(instrumentation-nestjs): update nestjs supported versions#2790
chore(instrumentation-nestjs): update nestjs supported versions#2790pichlermarc merged 1 commit intoopen-telemetry:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2790 +/- ##
=======================================
Coverage 89.45% 89.45%
=======================================
Files 174 174
Lines 8319 8319
Branches 1592 1592
=======================================
Hits 7442 7442
Misses 877 877 🚀 New features to boost your workflow:
|
|
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
|
@neilime Updated this and I think just accidentally forgot to update the readme. I understand the sentiment about maintenance but does it make sense to go ahead and merge this @david-luna? |
pichlermarc
left a comment
There was a problem hiding this comment.
Thanks @anuraaga 🙂
#2685 added support for NestJS 11 and I can confirm the latest released artifact works fine with it, so this updates the README to reflect it. I wasn't sure if it's better to remove <YY for YY that don't exist yet or keep it to not "pre-support" new major versions, let me know which is better.
Not pre-supporting is better - we do this to avoid breaking end users on new major versions.
Which problem is this PR solving?
Short description of the changes
#2685 added support for NestJS 11 and I can confirm the latest released artifact works fine with it, so this updates the README to reflect it. I wasn't sure if it's better to remove
<YYforYYthat don't exist yet or keep it to not "pre-support" new major versions, let me know which is better.