feat(baggage-log-record-processor): add package baggage log record processor#2754
Merged
trentm merged 17 commits intoopen-telemetry:mainfrom Mar 28, 2025
Merged
feat(baggage-log-record-processor): add package baggage log record processor#2754trentm merged 17 commits intoopen-telemetry:mainfrom
trentm merged 17 commits intoopen-telemetry:mainfrom
Conversation
…trib into baggage-log-processor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2754 +/- ##
==========================================
+ Coverage 89.44% 89.46% +0.01%
==========================================
Files 172 174 +2
Lines 8310 8324 +14
Branches 1591 1593 +2
==========================================
+ Hits 7433 7447 +14
Misses 877 877
🚀 New features to boost your workflow:
|
david-luna
reviewed
Mar 19, 2025
Contributor
david-luna
left a comment
There was a problem hiding this comment.
A couple of quick suggestions. I'll give more feedback on a second review :)
Co-authored-by: David Luna <david.luna@elastic.co>
david-luna
reviewed
Mar 19, 2025
…trib into baggage-log-processor
Contributor
|
CI failure is happening in |
…trib into baggage-log-processor
trentm
approved these changes
Mar 27, 2025
| { | ||
| "name": "@opentelemetry/baggage-log-record-processor", | ||
| "version": "0.0.1", | ||
| "description": "OpenTelemetry Baggage Log Record Processor for Node.js", |
Contributor
There was a problem hiding this comment.
"for Node.js"? I know you are just copying from baggage-span-processor here. Is there anything Node.js-specific in this package?
Contributor
Author
There was a problem hiding this comment.
good point, I was just using the same definition. Let me update it to be more generic
…trib into baggage-log-processor
trentm
approved these changes
Mar 27, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creation of Baggage Log Record Processor. The approach is very similar to the existent BaggageSpanProcessor.
Creating this new package to align with other SDKs who also have this (e.g. Java and .NET)
This processor adds attributes to LogRecords that were in the baggage. All keys can be added or the user can filter by the ones they want.