feat!: widen peer dependency range to include zone.js v0.15.0 #2571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, weird. This compiles fine locally. 🤔 |
pichlermarc
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2571 +/- ##
==========================================
+ Coverage 90.79% 90.80% +0.01%
==========================================
Files 169 169
Lines 8026 8026
Branches 1635 1635
==========================================
+ Hits 7287 7288 +1
+ Misses 739 738 -1 |
pichlermarc
commented
Dec 5, 2024
| @@ -680,7 +680,7 @@ export class UserInteractionInstrumentation extends InstrumentationBase<UserInte | |||
| /** | |||
| * returns Zone | |||
| */ | |||
| getZoneWithPrototype(): ZoneTypeWithPrototype | undefined { | |||
| private _getZoneWithPrototype(): ZoneTypeWithPrototype | undefined { | |||
There was a problem hiding this comment.
Reviewer note: this is the breaking change - IIUC this was not intended to be exposed to the end-user. ZoneWithPrototype is in from internal-types and it leaked Zone.js types to the public API.
maryliag
approved these changes
Dec 5, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates peer-dependencies to allow for zone.js v0.15.0 to be used.
Supersedes #2561
Fixes #2559
BEGIN_COMMIT_OVERRIDE
feat: widen peer dependency range to include zone.js v0.15.0
fix(instrumentation-user-interaction)!: make getZoneWithPrototype() private to avoid leaking internal type
ZoneWithPrototypeEND_COMMIT_OVERRIDE