Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-pg): add error type to db duration metric #2476

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

maryliag
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Add error type to db duration operation metric. It uses the error codes from postgres, so we can limit cardinality and they're well known error codes.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (b043ffb) to head (ca67d83).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2476   +/-   ##
=======================================
  Coverage   90.74%   90.75%           
=======================================
  Files         156      156           
  Lines        7728     7730    +2     
  Branches     1590     1591    +1     
=======================================
+ Hits         7013     7015    +2     
  Misses        715      715           
Files with missing lines Coverage Δ
...elemetry-instrumentation-pg/src/instrumentation.ts 89.83% <ø> (ø)
...node/opentelemetry-instrumentation-pg/src/utils.ts 97.67% <100.00%> (+0.03%) ⬆️

@maryliag maryliag changed the title add error type to db duration metric feat(instrumentation-pg): add error type to db duration metric Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants