-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-sdk): add http status code attribute to aws sdk span if aws sdk v3 client exception occurs #2344
fix(aws-sdk): add http status code attribute to aws sdk span if aws sdk v3 client exception occurs #2344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pinging @blumamir for approval and merge. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2344 +/- ##
==========================================
- Coverage 90.97% 90.40% -0.57%
==========================================
Files 146 149 +3
Lines 7492 7370 -122
Branches 1502 1532 +30
==========================================
- Hits 6816 6663 -153
- Misses 676 707 +31
|
Thanks you @jj22ee for the contribution. npm run lint:fix |
@blumamir done! |
Which problem is this PR solving?
Fixes #2343
Short description of the changes
http.status.code
attribute into the span upon client exceptions for AWS SDK V3 Spans.Testing
http.status.code
attribute