fix(auto-instrumentations-node): check if detector key in map rather than value false-iness #2313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than value false-iness
The committers listed above are authorized under a signed CLA. |
github-actions
bot
requested review from
blumamir,
dyladan,
legendecas and
pichlermarc
trentm
requested changes
Jul 4, 2024
There was a problem hiding this comment.
See #2311 (comment)
I believe a more appropriate fix would be on the sdk-node package in https://github.com/open-telemetry/opentelemetry-js/tree/main/experimental/packages/opentelemetry-sdk-node/
|
@qbedard thank you for documenting this issue and working on a fix. I too think the fix should be in sdk-node package. would you like to implement the fix there? |
|
Should be fixed in open-telemetry/opentelemetry-js#4879. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
#2311
Short description of the changes
In auto-instrumentations-node, the check for detector configuration values is evaluating the
false-iness of the map value, causing it to incorrectly treatDetector | Detector[]values asfalse-y. This PR changes that check to instead check for the the presence of the key value in the map.