-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(instrumentation-redis): Use exported semconv strings #2075
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2075 +/- ##
==========================================
- Coverage 90.97% 90.77% -0.21%
==========================================
Files 146 148 +2
Lines 7492 7675 +183
Branches 1502 1539 +37
==========================================
+ Hits 6816 6967 +151
- Misses 676 708 +32
|
@Zirak looks like you're missing the changes on |
Of course, silly me! Thanks for the spot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
…elemetry#2075) * refactor(instrumentation-redis): Use exported semconv strings Part of open-telemetry#2025. * chore(instrumentation-redis): Update package-lock --------- Co-authored-by: Jamie Danielson <[email protected]> Co-authored-by: Amir Blum <[email protected]> Co-authored-by: Marc Pichler <[email protected]>
Which problem is this PR solving?
I was already in the Redis neighborhood with #2072 and thought to help out, thanks @JamieDanielson and @maryliag for prior work on this.
Short description of the changes
For
@opentelemetry/instrumentation-redis
:@opentelemetry/semantic-conventions
to^1.22.0
SEMATTR
andDBSYSTEMVALUES
constants