Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mysql] implement semantic conventions #183

Merged

Conversation

naseemkullah
Copy link
Member

@naseemkullah naseemkullah commented Aug 25, 2020

Which problem is this PR solving?

partially #116

Short description of the changes

Using the semantic-conventions package and following specification. A function getDbStatement was extracted for building the statement by formatting sql with values.

@naseemkullah naseemkullah requested review from dyladan and a team August 25, 2020 04:17
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@naseemkullah naseemkullah requested a review from dyladan August 28, 2020 16:51
@dyladan dyladan changed the title feat: implement mysql semantic conventions [mysql] implement semantic conventions Aug 28, 2020
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #183 into master will decrease coverage by 0.96%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
- Coverage   96.18%   95.21%   -0.97%     
==========================================
  Files          81       92      +11     
  Lines        4167     4724     +557     
  Branches      423      488      +65     
==========================================
+ Hits         4008     4498     +490     
- Misses        159      226      +67     
Impacted Files Coverage Δ
node/opentelemetry-plugin-mysql/src/mysql.ts 95.61% <0.00%> (-0.26%) ⬇️
node/opentelemetry-plugin-mysql/test/mysql.test.ts 98.20% <0.00%> (-0.02%) ⬇️
node/opentelemetry-plugin-mysql/src/enums.ts
...in-dns/test/integrations/dnspromise-lookup.test.ts 91.37% <0.00%> (ø)
node/opentelemetry-plugin-dns/src/utils.ts 69.00% <0.00%> (ø)
.../opentelemetry-plugin-dns/test/utils/assertSpan.ts 100.00% <0.00%> (ø)
...elemetry-plugin-dns/test/functionals/utils.test.ts 98.82% <0.00%> (ø)
...ry-plugin-dns/test/integrations/dns-lookup.test.ts 92.50% <0.00%> (ø)
node/opentelemetry-plugin-dns/test/utils/utils.ts 33.33% <0.00%> (ø)
...entelemetry-plugin-dns/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
... and 6 more

@naseemkullah naseemkullah force-pushed the mysql-semantic-conventions branch from ef95cf0 to 8fdcd0d Compare September 2, 2020 04:32
@naseemkullah naseemkullah requested a review from obecny September 2, 2020 04:35
@obecny obecny added the enhancement New feature or request label Sep 7, 2020
@naseemkullah naseemkullah force-pushed the mysql-semantic-conventions branch from 0eae530 to 2c6e983 Compare September 8, 2020 00:46
@naseemkullah naseemkullah force-pushed the mysql-semantic-conventions branch from fc45ff0 to b3e29eb Compare September 8, 2020 01:46
@obecny obecny merged commit b856e10 into open-telemetry:master Sep 8, 2020
@naseemkullah naseemkullah deleted the mysql-semantic-conventions branch September 9, 2020 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants