Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(document-load): compatibility issue with @opentelemetry/[email protected] #1565

Merged
merged 2 commits into from
Jul 11, 2023
Merged

fix(document-load): compatibility issue with @opentelemetry/[email protected] #1565

merged 2 commits into from
Jul 11, 2023

Conversation

chigia001
Copy link
Contributor

@chigia001 chigia001 commented Jul 11, 2023 •
edited
Loading

Which problem is this PR solving?

  • new @opentelemetry/[email protected] which omit secureConnectionStart if the request if using http => this break some test in @opentelemetry/instrumentation-document-load

Short description of the changes

  • update minimum version of sdk-trace-web in instrumentation-document-load to 1.15.0
  • update test to remove check for secureConnectionStart

@chigia001 chigia001 requested a review from a team July 11, 2023 08:10
@github-actions github-actions bot requested review from martinkuba and pkanal July 11, 2023 08:11
@chigia001 chigia001 mentioned this pull request Jul 11, 2023
Closed
@chigia001
Copy link
Contributor Author

@Flarna merge this should force new cache key for other PR + fix Browser unit test when cache miss.

@Flarna
Copy link
Member

Flarna commented Jul 11, 2023

Do you have by chance a link to the PR which caused this?

pichlermarc
pichlermarc approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Flarna must've been open-telemetry/opentelemetry-js#3879
@chigia001 thank you for taking care of this.

@pichlermarc
Copy link
Member

Merging to unblock other PRs

@pichlermarc pichlermarc merged commit 774d254 into open-telemetry:main Jul 11, 2023
@dyladan dyladan mentioned this pull request Jul 11, 2023
Merged
@chigia001 chigia001 deleted the sdk-trace-web-1.15-compatibility-issue branch July 12, 2023 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

@Flarna Flarna Flarna approved these changes

@martinkuba martinkuba Awaiting requested review from martinkuba

@pkanal pkanal Awaiting requested review from pkanal

Assignees

@martinkuba martinkuba

@pkanal pkanal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chigia001 @Flarna @pichlermarc @martinkuba @pkanal