Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove support for node 8-12, add 18 #1065

Merged
merged 12 commits into from
Sep 15, 2022

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Jun 22, 2022

Which problem is this PR solving?

It's a complimentary PR for open-telemetry/opentelemetry-js#3048

Short description of the changes

Required changes for node@18:

  • 1e6bddf: turned off tests for alibaba detector in node@18.
  • fceb7b7: turned off tests for fastify instrumentation in node@18
  • 0067aec: error message used in tests changed
  • ef29bcf: Changed how root context equality is checked. Check the commit message.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1065 (f8254b7) into main (6c75487) will decrease coverage by 3.72%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1065      +/-   ##
==========================================
- Coverage   96.07%   92.35%   -3.73%     
==========================================
  Files          14      128     +114     
  Lines         892     6198    +5306     
  Branches      191     1213    +1022     
==========================================
+ Hits          857     5724    +4867     
- Misses         35      474     +439     
Impacted Files Coverage Δ
...ode/opentelemetry-instrumentation-net/src/types.ts 100.00% <0.00%> (ø)
...ages/opentelemetry-host-metrics/src/BaseMetrics.ts 100.00% <0.00%> (ø)
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 97.44% <0.00%> (ø)
...ource-detector-aws/src/detectors/AwsEcsDetector.ts 100.00% <0.00%> (ø)
...lemetry-instrumentation-net/src/instrumentation.ts 98.07% <0.00%> (ø)
...lemetry-instrumentation-dns/src/instrumentation.ts 76.38% <0.00%> (ø)
...etry-instrumentation-router/src/instrumentation.ts 96.15% <0.00%> (ø)
.../opentelemetry-instrumentation-graphql/src/enum.ts 100.00% <0.00%> (ø)
...-instrumentation-nestjs-core/src/enums/NestType.ts 100.00% <0.00%> (ø)
...telemetry-instrumentation-restify/src/constants.ts 100.00% <0.00%> (ø)
... and 104 more

@rauno56 rauno56 force-pushed the chore/drop-eol-node branch from 0289f96 to ef29bcf Compare June 27, 2022 16:09
@rauno56 rauno56 marked this pull request as ready for review June 27, 2022 17:53
@rauno56 rauno56 requested a review from a team June 27, 2022 17:53
@rauno56 rauno56 changed the title chore: remove node 8 and 10 support add 18 chore: remove support for node 8-12, add 18 Jun 27, 2022
@github-actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

…, not reference equality

In the CI there will be 3 instances of the API installed(relative to the repo root):

- `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/api`,
- `./node_modules/@opentelemetry/api`,
- `./plugins/node/opentelemetry-instrumentation-fastify/node_modules/@opentelemetry/instrumentation-http/node_modules/@opentelemetry/api`.
@rauno56 rauno56 merged commit 1277ce4 into open-telemetry:main Sep 15, 2022
@rauno56 rauno56 deleted the chore/drop-eol-node branch September 15, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants