Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/web/README: links to packages/opentelemetry-web result in 404s #623

Closed
chalin opened this issue Aug 17, 2021 · 2 comments · Fixed by #664
Closed

examples/web/README: links to packages/opentelemetry-web result in 404s #623

chalin opened this issue Aug 17, 2021 · 2 comments · Fixed by #664
Assignees

Comments

@chalin
Copy link
Contributor

chalin commented Aug 17, 2021

It seems like the 404s have there been since open-telemetry/opentelemetry-js#2340.

I suppose that the references to packages/opentelemetry-web will be updated to https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-sdk-trace-web once @opentelemetry/sdk-trace-web is officially released? (I only see alpha versions now.)

In the meantime, it might make sense to link https://github.com/open-telemetry/opentelemetry-js/tree/v0.24.0/packages/opentelemetry-web so that we can avoid 404s?

If you like, I can submit a PR with these link updates. Let me know.

@dyladan
Copy link
Member

dyladan commented Sep 1, 2021

I suppose that the references to packages/opentelemetry-web will be updated to https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-sdk-trace-web once @opentelemetry/sdk-trace-web is officially released? (I only see alpha versions now.)

Yes.

In the meantime, it might make sense to link https://github.com/open-telemetry/opentelemetry-js/tree/v0.24.0/packages/opentelemetry-web so that we can avoid 404s?

If you like, I can submit a PR with these link updates. Let me know.

I would appreciate that

@chalin
Copy link
Contributor Author

chalin commented Sep 16, 2021

#635 renamed the package to @opentelemetry/sdk-trace-web, so in #664, I fixed the links accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants